Round duration for measures to nearest ms (#4)

nicjansma · Sep 15, 2016 · 2e13055 · 2e13055
1 parent e06b944
commit 2e13055
Show file tree

Hide file tree

Showing 6 changed files with 17 additions and 6 deletions.
diff --git a/README.md b/README.md
@@ -1,6 +1,6 @@
 # usertiming-compression.js
 
-v0.1.3
+v0.1.4
 
 [http://nicj.net](http://nicj.net)
 
@@ -205,6 +205,7 @@ Or via ``gulp``:
 * v0.1.1 - 2016-04-04: `getCompressedUserTiming()` gathers Measures that end after the specified `from`
 * v0.1.2 - 2016-04-04: Protect against X-O frame access that crashes some browsers
 * v0.1.3 - 2016-07-25: `getCompressedUserTiming()` accepts an alternate window param passed into options
+* v0.1.4 - 2016-08-10: Round `duration` values on Measures to nearest millisecond
 
 ## Thanks
 

diff --git a/bower.json b/bower.json
@@ -1,6 +1,6 @@
 {
   "name": "usertiming-compression",
-  "version": "0.1.3",
+  "version": "0.1.4",
   "homepage": "https://github.com/nicjansma/usertiming-compression.js",
   "authors": [
     "Nic Jansma <nic@nicj.net>"

diff --git a/dist/usertiming-compression.min.js b/dist/usertiming-compression.min.js
diff --git a/package.json b/package.json
@@ -3,7 +3,7 @@
   "description": "UserTiming compression and decompression",
   "main": "./src/usertiming-compression",
   "author": "Nic Jansma",
-  "version": "0.1.3",
+  "version": "0.1.4",
   "repository": {
     "type": "git",
     "url": "http://github.com/nicjansma/usertiming-compression.js.git"

diff --git a/src/usertiming-compression.js b/src/usertiming-compression.js
@@ -195,8 +195,9 @@
                     var finalValue = time;
 
                     // if this is a measure (with a duration), tack on "_[duration]"
-                    if (typeof value.duration !== "undefined") {
-                        var duration = self.toBase36(value.duration);
+                    if (typeof value.duration === "number") {
+                        // round duration to nearest ms
+                        var duration = self.toBase36(Math.round(value.duration));
 
                         finalValue += "_";
 

diff --git a/test/test-usertiming-compression.js b/test/test-usertiming-compression.js
@@ -118,6 +118,15 @@
                 }])).to.deep.equal({"measure1": "1_1"});
             });
 
+            it("should compress a single measure with a rounded duration", function() {
+                expect(utc.compressUserTiming([{
+                    entryType: "measure",
+                    name: "measure1",
+                    startTime: 1,
+                    duration: 0.750
+                }])).to.deep.equal({"measure1": "1_1"});
+            });
+
             it("should compress a single measure with a duration of 0", function() {
                 expect(utc.compressUserTiming([{
                     entryType: "measure",