Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make hostname reversal configurable #20

Merged
merged 6 commits into from
Apr 13, 2018
Merged

Make hostname reversal configurable #20

merged 6 commits into from
Apr 13, 2018

Conversation

bluesmoon
Copy link
Contributor

@bluesmoon bluesmoon commented Apr 13, 2018 •
edited
Loading

This patch does three things:

  1. Make hostname reversal configurable via ResourceTimingDecompression.HOSTNAME_REVERSED
  2. Add naturalHeight/Width to dimensionData
  3. Fix up optional fields in dimensionData

nicjansma
nicjansma requested changes Apr 13, 2018
View reviewed changes
Copy link
Owner

@nicjansma nicjansma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests failing: https://travis-ci.org/nicjansma/resourcetiming-compression.js/jobs/366131146

There's also a lint warning

@nicjansma nicjansma merged commit d61c254 into nicjansma:master Apr 13, 2018
@bluesmoon bluesmoon deleted the optional-hostname-reversal branch April 13, 2018 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicjansma nicjansma nicjansma approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bluesmoon @nicjansma