Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove redundant hasOwnProperty check #18

Merged
merged 1 commit into from
Apr 13, 2018
Merged

Remove redundant hasOwnProperty check #18

merged 1 commit into from
Apr 13, 2018

Conversation

Krinkle
Copy link
Contributor

@Krinkle Krinkle commented Mar 29, 2018

This conditional continue is the same as the one at the start
of the iteration 5 lines up, and nothing in between appears
to be capable of changing the outcome of that condition (eg.
adding the property, or something like that).

@Krinkle
Remove redundant hasOwnProperty check
01916c1 
This conditional continue is the same as the one at the start
of the iteration 5 lines up, and nothing in between appears
to be capable of changing the outcome of that condition (eg.
adding the property, or something like that).
@nicjansma
Copy link
Owner

Great catch!

@nicjansma nicjansma merged commit 5dadf05 into nicjansma:master Apr 13, 2018
@Krinkle Krinkle deleted the rm-dup-check branch April 13, 2018 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Krinkle @nicjansma